[libvirt] [PATCH v1 3/7] tests: Add test case for virtio-gpu-ccw

[Farhan Ali]

On 03/16/2018 09:39 AM, John Ferlan wrote:
> 
> 
> On 03/08/2018 11:07 AM, Farhan Ali wrote:
>> A test case to test the virtio-gpu-ccw device.
>>
>> Signed-off-by: Farhan Ali <alifm at linux.vnet.ibm.com>
>> Signed-off-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
>> ---
>>   .../qemuxml2argvdata/video-virtio-gpu-ccw-auto.xml | 18 ++++++++++
>>   tests/qemuxml2argvdata/video-virtio-gpu-ccw.args   | 25 ++++++++++++++
>>   tests/qemuxml2argvdata/video-virtio-gpu-ccw.xml    | 35 ++++++++++++++++++++
>>   tests/qemuxml2argvtest.c                           |  7 ++++
>>   .../video-virtio-gpu-ccw-auto.xml                  | 34 +++++++++++++++++++
>>   tests/qemuxml2xmloutdata/video-virtio-gpu-ccw.xml  | 38 ++++++++++++++++++++++
>>   tests/qemuxml2xmltest.c                            | 14 ++++++++
>>   7 files changed, 171 insertions(+)
>>   create mode 100644 tests/qemuxml2argvdata/video-virtio-gpu-ccw-auto.xml
>>   create mode 100644 tests/qemuxml2argvdata/video-virtio-gpu-ccw.args
>>   create mode 100644 tests/qemuxml2argvdata/video-virtio-gpu-ccw.xml
>>   create mode 100644 tests/qemuxml2xmloutdata/video-virtio-gpu-ccw-auto.xml
>>   create mode 100644 tests/qemuxml2xmloutdata/video-virtio-gpu-ccw.xml
>>
> 
> The tests look OK - could have been merged with the "functionality"
> patch, but it's OK that they're separate - as long as they exist it's a
> good thing.
> 
> I assume the xml2xml output would be "valid" after the "capability"
> patch - if so you could extract it into it's own patch if you felt
> really compelled to do so.
> 
> John
> 

I just feel it's easier to understand to have them all in one patch :)