[libvirt] [dbus PATCH 5/8] maint: set the first minimal version that will be released

[Daniel P. Berrangé]

On Mon, Mar 19, 2018 at 10:30:49AM +0100, Pavel Hrdina wrote:
> We will require libvirt to have at least the same version as
> libvirt-dbus.  The 1.2.12 version is the lowest one which we will
> support since it introduced virDomainDefineXMLFlags() and we don't
> have to support the non-flags APIs.
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  configure.ac | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index df1a375..ba397ca 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1,4 +1,4 @@
> -AC_INIT([libvirt-dbus], [0.0.1], [libvir-list at redhat.com], [], [http://libvirt.org])
> +AC_INIT([libvirt-dbus], [1.2.12], [libvir-list at redhat.com], [], [http://libvirt.org])
>  
>  AC_CONFIG_SRCDIR(src/main.c)
>  AC_CONFIG_AUX_DIR([build-aux])
> @@ -11,7 +11,7 @@ AC_USE_SYSTEM_EXTENSIONS
>  
>  AM_SILENT_RULES([yes])
>  
> -LIBVIRT_REQUIRED=1.2.8
> +LIBVIRT_REQUIRED=AC_PACKAGE_VERSION

This feels a bit odd to me - what will you set the AC_INIT version to
if you want todo 5 releases of libvirt-dbus, without bumping the min
required version of libvirt.

I can understand having the libvirt-dbus versions be set in lockstep to
libvirt versions in AC_INIT, if you plan to always do a libvirt-dbus
release on the 1st of the month at same time as libvirt, but even then
I doubt you'd want to set min required libvirt to match.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|