[libvirt] [PATCH 2/3] libxl: call EndJob in error case

Jim Fehlig jfehlig at suse.com
Mon Mar 19 23:14:52 UTC 2018


If starting the domain fails in libxlDomainCreateXML, we mistakenly
jumped to cleanup without calling libxlDomainObjEndJob. Remove the
jump to 'cleanup'.

Signed-off-by: Jim Fehlig <jfehlig at suse.com>
---
 src/libxl/libxl_driver.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index ac61fb322..3ebeacca8 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
@@ -1066,7 +1066,6 @@ libxlDomainCreateXML(virConnectPtr conn, const char *xml,
         if (!vm->persistent) {
             virDomainObjListRemove(driver->domains, vm);
             virObjectLock(vm);
-            goto cleanup;
         }
         goto endjob;
     }
-- 
2.16.2




More information about the libvir-list mailing list