[libvirt] [jenkins-ci PATCH 2/3] guests: Don't expose 'jenkins' pseudo-package

[Pavel Hrdina]

On Tue, Mar 20, 2018 at 05:23:59PM +0100, Andrea Bolognani wrote:
> The 'jenkins' pseudo-package is an implementation detail, and
> as such is better not exposed.
> 
> Moreover, with this change the JDK will only be installed when
> the 'jenkins' flavor is used, which means developers will have
> slightly smaller guests.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  guests/host_vars/libvirt-centos-6/main.yml       | 1 -
>  guests/host_vars/libvirt-centos-7/main.yml       | 1 -
>  guests/host_vars/libvirt-debian-8/main.yml       | 1 -
>  guests/host_vars/libvirt-debian-9/main.yml       | 1 -
>  guests/host_vars/libvirt-fedora-26/main.yml      | 1 -
>  guests/host_vars/libvirt-fedora-27/main.yml      | 1 -
>  guests/host_vars/libvirt-fedora-rawhide/main.yml | 1 -
>  guests/host_vars/libvirt-freebsd-10/main.yml     | 1 -
>  guests/host_vars/libvirt-freebsd-11/main.yml     | 1 -
>  guests/site.yml                                  | 7 +++++++
>  10 files changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/guests/site.yml b/guests/site.yml
> index 8d32561..509d31a 100644
> --- a/guests/site.yml
> +++ b/guests/site.yml
> @@ -28,6 +28,13 @@
>        when:
>          - projects is defined
>  
> +    # Install packages needed for the Jenkins agent
> +    - include: tasks/packages.yml
> +      vars:
> +        project: jenkins
> +      when:
> +        - flavor == "jenkins"
> +
>      # Configure the Jenkins agent
>      - include: tasks/jenkins.yml
>        when:

Would it make sense to move the installation of packages needed
for Jenkins agent into the jenkins task to create a single unit
out of it?

Otherwise looks good.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180321/b660590b/attachment-0001.sig>