[libvirt] [jenkins-ci PATCH 3/3] guests: Don't expose 'base' pseudo-package

[Pavel Hrdina]

On Tue, Mar 20, 2018 at 05:24:00PM +0100, Andrea Bolognani wrote:
> The 'base' pseudo-package is an implementation detail, and as
> such is better not exposed.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  guests/host_vars/libvirt-centos-6/main.yml        | 1 -
>  guests/host_vars/libvirt-centos-7/main.yml        | 1 -
>  guests/host_vars/libvirt-debian-8/main.yml        | 1 -
>  guests/host_vars/libvirt-debian-9/main.yml        | 1 -
>  guests/host_vars/libvirt-debian-sid/main.yml      | 1 -
>  guests/host_vars/libvirt-fedora-26/main.yml       | 1 -
>  guests/host_vars/libvirt-fedora-27/main.yml       | 1 -
>  guests/host_vars/libvirt-fedora-rawhide/main.yml  | 1 -
>  guests/host_vars/libvirt-freebsd-10/main.yml      | 1 -
>  guests/host_vars/libvirt-freebsd-11/main.yml      | 1 -
>  guests/host_vars/libvirt-freebsd-current/main.yml | 1 -
>  guests/host_vars/libvirt-ubuntu-12/main.yml       | 1 -
>  guests/host_vars/libvirt-ubuntu-14/main.yml       | 1 -
>  guests/host_vars/libvirt-ubuntu-16/main.yml       | 1 -
>  guests/site.yml                                   | 5 +++++
>  15 files changed, 5 insertions(+), 14 deletions(-)
>
> diff --git a/guests/site.yml b/guests/site.yml
> index 509d31a..4207d4e 100644
> --- a/guests/site.yml
> +++ b/guests/site.yml
> @@ -19,6 +19,11 @@
>      - include: tasks/compat.yml
>      - include: tasks/user.yml
>  
> +    # Install base packages
> +    - include: tasks/packages.yml
> +      vars:
> +        project: base
> +

The same question as for the jenkins packages, would it make sense to
move it into the base.yml task?

Otherwise looks good.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180321/5ada181f/attachment-0001.sig>