[libvirt] [jenkins-ci PATCH 4/3] guests: Remove ad-hoc package installation

[Pavel Hrdina]

On Wed, Mar 21, 2018 at 01:19:57PM +0100, Andrea Bolognani wrote:
> There is a small number of packages that we install as part of
> the 'base' task with an ad-hoc call to the package module.
> 
> Since we have generic facilities for installing packages and a
> generic 'base' pseudo-project that we use for all packages that
> are not related to any specific project, we can fold everything
> into it and have a single source of truth.
> 
> The change requires us to delay user creation, though, because
> as part of that we edit the sudoers file, which doesn't exist
> until the sudo package has been installed.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  guests/site.yml               |  7 +++++--
>  guests/tasks/base.yml         | 11 -----------
>  guests/vars/mappings.yml      | 15 +++++++++++++++
>  guests/vars/projects/base.yml |  5 +++++
>  4 files changed, 25 insertions(+), 13 deletions(-)
> 
> diff --git a/guests/site.yml b/guests/site.yml
> index 4207d4e..d057116 100644
> --- a/guests/site.yml
> +++ b/guests/site.yml
> @@ -14,16 +14,19 @@
>  
>    tasks:
>  
> -    # Prepare the base environment
> +    # Prepare environment. None of the actions performed here might
> +    # depend on packages being installed
>      - include: tasks/base.yml
>      - include: tasks/compat.yml
> -    - include: tasks/user.yml
>  
>      # Install base packages
>      - include: tasks/packages.yml
>        vars:
>          project: base
>  
> +    # Create users. This needs to happen after installing base packages
> +    - include: tasks/user.yml
> +

This would be solved by moving the package installation into the base
task.

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180321/9a0bdda1/attachment-0001.sig>