[libvirt] [jenkins-ci PATCH 4/3] guests: Remove ad-hoc package installation

[Pavel Hrdina]

On Wed, Mar 21, 2018 at 04:17:48PM +0100, Andrea Bolognani wrote:
> On Wed, 2018-03-21 at 16:03 +0100, Pavel Hrdina wrote:
> > > -    # Prepare the base environment
> > > +    # Prepare environment. None of the actions performed here might
> > > +    # depend on packages being installed
> > >      - include: tasks/base.yml
> > >      - include: tasks/compat.yml
> > > -    - include: tasks/user.yml
> > >  
> > >      # Install base packages
> > >      - include: tasks/packages.yml
> > >        vars:
> > >          project: base
> > >  
> > > +    # Create users. This needs to happen after installing base packages
> > > +    - include: tasks/user.yml
> > > +
> > 
> > This would be solved by moving the package installation into the base
> > task.
> 
> Not really: the ordering requirement would still be present, just
> hidden inside base.yml. You would still need to make sure base.yml
> is included before user.yml.
> 
> I guess it's really up to preference, at the end of the day. As
> mentioned in the other message, I like the flat structure better :)

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180321/4b44ad01/attachment-0001.sig>