[libvirt] [PATCH v6.1 4/9] libxl: do not enable nested HVM unless global nested_hvm option enabled

[Daniel P. Berrangé]

On Thu, Mar 22, 2018 at 01:15:31AM +0100, Marek Marczykowski-Górecki wrote:
> Introduce global libxl option for enabling nested HVM feature, similar
> to kvm module parameter. This will prevent enabling experimental feature
> by mere presence of <cpu mode='host-passthrough'> element in domain
> config, unless explicitly enabled. <cpu mode='host-passthrough'> element
> may be used to configure other features, like NUMA, or CPUID.
> 
> Signed-off-by: Marek Marczykowski-Górecki <marmarek at invisiblethingslab.com>
> Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
> Changes since v6:
>  - really allow per-domain override
> Changes since v4:
>  - add nested_hvm option to test_libvirtd_libxl.aug.in and libvirtd_libxl.aug
>  - make it possible to override nested_hvm=0 with explicit <feature
>    policy='require' name='vmx'/>
>  - split xenconfig changes into separate commits
> Changes since v3:
>  - use config option nested_hvm, instead of requiring explicit <feature
>    ...> entries
>  - title changed from "libxl: do not enable nested HVM by mere presence
>    of <cpu> element"
>  - xenconfig: don't add <feature policy='force' name='vmx'/> since it is
>    implied by presence of <cpu> element
>  - xenconfig: produce <cpu> element even when converting on host not
>    supporting vmx/svm, to not lose setting value
> Changes since v2:
>  - new patch
> ---
>  src/libxl/libvirtd_libxl.aug         |  2 ++
>  src/libxl/libxl.conf                 |  8 ++++++++
>  src/libxl/libxl_conf.c               | 12 +++++++++++-
>  src/libxl/libxl_conf.h               |  2 ++
>  src/libxl/test_libvirtd_libxl.aug.in |  1 +
>  tests/libxlxml2domconfigtest.c       |  3 +++
>  6 files changed, 27 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|