[libvirt] [PATCHv2 00/25] Python tweaks

Ján Tomko jtomko at redhat.com
Thu Mar 22 13:20:54 UTC 2018


On Tue, Mar 20, 2018 at 06:48:43AM +0000, Radostin Stoyanov wrote:
>Changes since v1 (https://www.redhat.com/archives/libvir-list/2018-March/msg01001.html)
>
>01 - Fixed typo.
>03 - Added whitespace after comma in: value = value + re.sub("^(\d+)U$","\\1", token[1])
>05 and 06 - Use printf style format and break strings everywhere there is a newline.
>07 - Use try-except instead of an explicit check.
>10 - Use isalnum() instead of a regex match, and a few more simplifications were added.
>20 - Use try-except instead of an explicit check.
>23 - Don't slice `line` in the loop condition.
>
>New patches: 9, 24, 25
>
>The patches have been tested with `make check`, `make syntax-check`.
>The output of apibuild.py was tested with `cd docs/` followed by:
>
>	srcdir=. builddir=. /usr/bin/python2 ./apibuild.py; sha1sum *.xml | sha1sum
>
>and
>
>	srcdir=. builddir=. /usr/bin/python3 ./apibuild.py; sha1sum *.xml | sha1sum
>
>before and after the patches were applied.
>

The apibuild.py script was borrowed from libxml2 IIRC. I don't know what
the python3-compatibility status is over there, but it could benefit
from some of the cleanups if you're feeling adventurous ;)

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180322/cc1a5cdf/attachment-0001.sig>


More information about the libvir-list mailing list