[libvirt] [PATCH v2 2/7] qemu: Add support for virtio-gpu-ccw video device on S390

Ján Tomko jtomko at redhat.com
Thu Mar 22 19:18:28 UTC 2018


On Mon, Mar 19, 2018 at 02:35:30PM -0400, Farhan Ali wrote:
>QEMU on S390 (since v2.11) can support the virtio-gpu-ccw device,
>which can be used as a video device.
>
>Signed-off-by: Farhan Ali <alifm at linux.vnet.ibm.com>
>---
> docs/formatdomain.html.in      |  3 +++
> src/qemu/qemu_command.c        | 13 +++++++++++--
> src/qemu/qemu_domain.c         |  2 +-
> src/qemu/qemu_domain_address.c | 12 ++++++++++--
> src/qemu/qemu_process.c        |  5 ++++-
> 5 files changed, 29 insertions(+), 6 deletions(-)
>

>diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
>index 7022f7c..4aaf617 100644
>--- a/src/qemu/qemu_domain.c
>+++ b/src/qemu/qemu_domain.c
>@@ -5425,7 +5425,7 @@ qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,
>         if (dev->data.video->type == VIR_DOMAIN_VIDEO_TYPE_DEFAULT) {
>             if (ARCH_IS_PPC64(def->os.arch))
>                 dev->data.video->type = VIR_DOMAIN_VIDEO_TYPE_VGA;
>-            else if (qemuDomainIsVirt(def))
>+            else if (qemuDomainIsVirt(def) || ARCH_IS_S390(def->os.arch))
>                 dev->data.video->type = VIR_DOMAIN_VIDEO_TYPE_VIRTIO;
>             else
>                 dev->data.video->type = VIR_DOMAIN_VIDEO_TYPE_CIRRUS;

This hunk which does not 'add support' but 'changes the default' belongs
in a separate patch IMO.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180322/796166d6/attachment-0001.sig>


More information about the libvir-list mailing list