[libvirt] [PATCH v2 3/7] tests: Add test cases for virtio-gpu-ccw

[Farhan Ali]

On 03/22/2018 03:27 PM, Ján Tomko wrote:
> On Mon, Mar 19, 2018 at 02:35:31PM -0400, Farhan Ali wrote:
>> A test cases to test the virtio-gpu-ccw device.
>>
>> Signed-off-by: Farhan Ali <alifm at linux.vnet.ibm.com>
>> Signed-off-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
>> ---
>> .../qemuxml2argvdata/video-virtio-gpu-ccw-auto.xml | 18 ++++++++++
>> tests/qemuxml2argvdata/video-virtio-gpu-ccw.args   | 25 ++++++++++++++
>> tests/qemuxml2argvdata/video-virtio-gpu-ccw.xml    | 35 
>> +++++++++++++++++++
>> tests/qemuxml2argvtest.c                           |  7 ++++
>> .../video-virtio-gpu-ccw-auto.xml                  | 35 
>> +++++++++++++++++++
>> tests/qemuxml2xmloutdata/video-virtio-gpu-ccw.xml  | 39 
>> ++++++++++++++++++++++
>> tests/qemuxml2xmltest.c                            | 14 ++++++++
>> 7 files changed, 173 insertions(+)
> 
> Test cases can be squashed into commits adding the functionality to
> demonstrate what it does and the rest should be added as early as
> possible to show that later patches do not break it.
> 

Understood and it makes sense.


> If I understand correctly:
> qemuxml2xml: -ccw.xml should work even as a first patch of the series
> (and since the only difference between the input and the output file
>   is virtio-gpu unrelated, just taking the current output as the new
>   input and symlinking the outfile should be enough)

Well the 'graphics' tag auto generates some default values, so symlink 
might not work.

> qemuxml2xml: -auto-ccw.xml belongs with the patch changing the default
> and the tests/qemuxml2argvtest.c and .args changes belong with the
> command line formatter

Okay, will change.

> 
> Jan
> 
>> create mode 100644 tests/qemuxml2argvdata/video-virtio-gpu-ccw-auto.xml
>> create mode 100644 tests/qemuxml2argvdata/video-virtio-gpu-ccw.args
>> create mode 100644 tests/qemuxml2argvdata/video-virtio-gpu-ccw.xml
>> create mode 100644 tests/qemuxml2xmloutdata/video-virtio-gpu-ccw-auto.xml
>> create mode 100644 tests/qemuxml2xmloutdata/video-virtio-gpu-ccw.xml
>>
> 
> 
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>