[libvirt] [PATCH] remote: remove some __sun conditionals
abologna at redhat.com
Fri Mar 23 12:01:44 UTC 2018
On Fri, 2018-03-23 at 11:02 +0000, Daniel P. Berrangé wrote:
> The libvirtd daemon has some arbitrary logic to drop privileges, but
> only on Solaris platforms. This was added during Xen days, when Xen was
> the only driver running in libvirtd. There's no expectation or testing
> that this works with the new libxl stack, nor whether dropping
> privileges breaks any of the secondary drivers. Finally, we'll be
> splitting drivers out into their own independant daemons, so this won't
> be applicable to libvirtd in future anyway.
> The remote driver client meanwhile arbitrarily disables daemon
> auto-spawn when connecting as non-root, breaking a key feature of
> libvirt unprivileged connections.
> Since we've not had any contributions for Solaris since circa 2012
> and we don't do any CI testing we should consider this platform
> unmaintained and thus reasonable to remove this cruft. If someone steps
> forward to maintain Solaris again, this code would need re-evaluating to
> come up with something more targetted.
> There's various __sun conditionals in the Xen driver code, but those are
> not touched. This is all for the legacy Xen driver, which will be
> entirely removed at some point in future, so not benefit to hacking out
> just the Solaris parts.
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> src/remote/remote_daemon.c | 33 ---------------------------------
> src/remote/remote_driver.c | 2 --
> 2 files changed, 35 deletions(-)
Looks reasonable enough.
Reviewed-by: Andrea Bolognani <abologna at redhat.com>
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list