[libvirt] [dbus PATCH 06/10] Create API method: Renamed to CreateWithFlags

Katerina Koukiou kkoukiou at redhat.com
Fri Mar 23 14:17:03 UTC 2018


Same for internal virtDBusDomainCreate:
Renamed to virtDBusDomainCreatewithFlags

Following naming from libvirt API.

Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
---
 data/org.libvirt.Domain.xml |  2 +-
 src/domain.c                | 16 ++++++++--------
 test/test_domain.py         |  2 +-
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index 0f6743d..3afee78 100644
--- a/data/org.libvirt.Domain.xml
+++ b/data/org.libvirt.Domain.xml
@@ -34,7 +34,7 @@
     <method name="Reset">
       <arg name="flags" type="u" direction="in"/>
     </method>
-    <method name="Create">
+    <method name="CreateWithFlags">
       <arg name="flags" type="u" direction="in"/>
     </method>
     <method name="Undefine"/>
diff --git a/src/domain.c b/src/domain.c
index fee7f47..6b1779a 100644
--- a/src/domain.c
+++ b/src/domain.c
@@ -401,13 +401,13 @@ virtDBusDomainReset(GVariant *inArgs,
 }
 
 static void
-virtDBusDomainCreate(GVariant *inArgs G_GNUC_UNUSED,
-                     GUnixFDList *inFDs G_GNUC_UNUSED,
-                     const gchar *objectPath G_GNUC_UNUSED,
-                     gpointer userData,
-                     GVariant **outArgs G_GNUC_UNUSED,
-                     GUnixFDList **outFDs G_GNUC_UNUSED,
-                     GError **error)
+virtDBusDomainCreateWithFlags(GVariant *inArgs G_GNUC_UNUSED,
+                              GUnixFDList *inFDs G_GNUC_UNUSED,
+                              const gchar *objectPath G_GNUC_UNUSED,
+                              gpointer userData,
+                              GVariant **outArgs G_GNUC_UNUSED,
+                              GUnixFDList **outFDs G_GNUC_UNUSED,
+                              GError **error)
 {
     virtDBusConnect *connect = userData;
     g_autoptr(virDomain) domain = NULL;
@@ -463,7 +463,7 @@ static virtDBusGDBusMethodTable virtDBusDomainMethodTable[] = {
     { "Destroy", virtDBusDomainDestroy },
     { "Reboot", virtDBusDomainReboot },
     { "Reset", virtDBusDomainReset },
-    { "Create", virtDBusDomainCreate },
+    { "CreateWithFlags", virtDBusDomainCreateWithFlags },
     { "Undefine", virtDBusDomainUndefine },
     { NULL, NULL }
 };
diff --git a/test/test_domain.py b/test/test_domain.py
index ae722fd..bf0f149 100755
--- a/test/test_domain.py
+++ b/test/test_domain.py
@@ -33,7 +33,7 @@ class TestDomain(libvirttest.BaseTestClass):
 
         domain.Reboot(0)
         domain.ShutdownFlags(0)
-        domain.Create(0)
+        domain.CreateWithFlags(0)
         domain.Destroy()
         domain.Undefine()
 
-- 
2.15.0




More information about the libvir-list mailing list