[libvirt] [dbus PATCH 08/10] Undefine API method: Renamed to UndefineFlags

Katerina Koukiou kkoukiou at redhat.com
Fri Mar 23 14:17:05 UTC 2018


Same for internal virtDBusDomainUndefine:
Renamed to virtDBusDomainUndefineFlags

Following naming from libvirt API

Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
---
 data/org.libvirt.Domain.xml |  2 +-
 src/domain.c                | 16 ++++++++--------
 test/test_domain.py         |  4 ++--
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index 05d0c9c..4b1a650 100644
--- a/data/org.libvirt.Domain.xml
+++ b/data/org.libvirt.Domain.xml
@@ -37,7 +37,7 @@
     <method name="CreateWithFlags">
       <arg name="flags" type="u" direction="in"/>
     </method>
-    <method name="Undefine">
+    <method name="UndefineFlags">
       <arg name="flags" type="u" direction="in"/>
     </method>
     <signal name="DeviceAdded">
diff --git a/src/domain.c b/src/domain.c
index 635af6a..cc4e692 100644
--- a/src/domain.c
+++ b/src/domain.c
@@ -424,13 +424,13 @@ virtDBusDomainCreateWithFlags(GVariant *inArgs G_GNUC_UNUSED,
 }
 
 static void
-virtDBusDomainUndefine(GVariant *inArgs G_GNUC_UNUSED,
-                       GUnixFDList *inFDs G_GNUC_UNUSED,
-                       const gchar *objectPath G_GNUC_UNUSED,
-                       gpointer userData,
-                       GVariant **outArgs G_GNUC_UNUSED,
-                       GUnixFDList **outFDs G_GNUC_UNUSED,
-                       GError **error)
+virtDBusDomainUndefineFlags(GVariant *inArgs G_GNUC_UNUSED,
+                            GUnixFDList *inFDs G_GNUC_UNUSED,
+                            const gchar *objectPath G_GNUC_UNUSED,
+                            gpointer userData,
+                            GVariant **outArgs G_GNUC_UNUSED,
+                            GUnixFDList **outFDs G_GNUC_UNUSED,
+                            GError **error)
 {
     virtDBusConnect *connect = userData;
     g_autoptr(virDomain) domain = NULL;
@@ -467,7 +467,7 @@ static virtDBusGDBusMethodTable virtDBusDomainMethodTable[] = {
     { "Reboot", virtDBusDomainReboot },
     { "Reset", virtDBusDomainReset },
     { "CreateWithFlags", virtDBusDomainCreateWithFlags },
-    { "Undefine", virtDBusDomainUndefine },
+    { "UndefineFlags", virtDBusDomainUndefineFlags },
     { NULL, NULL }
 };
 
diff --git a/test/test_domain.py b/test/test_domain.py
index cad1da5..e3f32ca 100755
--- a/test/test_domain.py
+++ b/test/test_domain.py
@@ -35,7 +35,7 @@ class TestDomain(libvirttest.BaseTestClass):
         domain.ShutdownFlags(0)
         domain.CreateWithFlags(0)
         domain.Destroy()
-        domain.Undefine(0)
+        domain.UndefineFlags(0)
 
     def test_shutdown(self):
         def domain_stopped(name, path):
@@ -63,7 +63,7 @@ class TestDomain(libvirttest.BaseTestClass):
 
         _, domain = self.domain()
         domain.ShutdownFlags(0)
-        domain.Undefine(0)
+        domain.UndefineFlags(0)
 
         self.main_loop()
 
-- 
2.15.0




More information about the libvir-list mailing list