[libvirt] [dbus PATCH v2 0/6] Use API calls supporting flags

Pavel Hrdina phrdina at redhat.com
Mon Mar 26 08:03:11 UTC 2018

On Fri, Mar 23, 2018 at 05:57:58PM +0100, Katerina Koukiou wrote:
> * Use API calls with flags parameter when possible
> * Since libvirt-dbus API doesn't follow strictly the naming
>   of libvirt API there should be documentation regarding which
>   libvirt API is used for each libvirt-dbus API.
>   This patch introduces documentation annotations in D-Bus Interface XML
>   files which will be used later to generate proper documentation.
> Katerina Koukiou (6):
>   virtDBusDomainGetVcpus: Should be implemented as method and not as
>     property
>   virtDBusDomainShutdown: Use virDomainShutdownFlags instead of
>     virDomainShutdown
>   virtDBusDomainCreate: Use virDomainCreateWithFlags instead of
>     virDomainCreate
>   virtDBusDomainUndefine: Use virDomainUndefineFlags instead of
>     virDomainUndefine
>   virtDBusDomainDestroy: Use virDomainDestroyFlags instead of
>     virDomainDestroy
>   Use Documentation Annotations in D-Bus Interface XML

Thanks for the patches, I'll fix the issues before pushing.

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180326/bd3b964c/attachment-0001.sig>

More information about the libvir-list mailing list