[libvirt] [PATCH 08/14] qemu: domain: Forbid VIR_STORAGE_FILE_ISO as a disk format

[Ján Tomko]

On Thu, Mar 29, 2018 at 01:51:05PM +0200, Peter Krempa wrote:
>This format is used by the storage driver and other hypervisors but qemu
>does not have nothion of the 'iso' format and libvirt does not translate

s/nothion/notion/

>it to anything useful, so it would not work anyways. Users should use
>'raw' instead.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_domain.c                        |  7 +++++++
> tests/qemuxml2argvdata/disk-drive-fmt-iso.xml | 27 +++++++++++++++++++++++++++
> tests/qemuxml2argvtest.c                      |  1 +
> 3 files changed, 35 insertions(+)
> create mode 100644 tests/qemuxml2argvdata/disk-drive-fmt-iso.xml
>
>diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
>index 88b4653da5..e02da9e608 100644
>--- a/src/qemu/qemu_domain.c
>+++ b/src/qemu/qemu_domain.c
>@@ -4124,6 +4124,13 @@ qemuDomainValidateStorageSource(virStorageSourcePtr src)
>         return -1;
>     }
>
>+    if (src->format == VIR_STORAGE_FILE_ISO) {
>+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
>+                       _("storage format 'iso' is not directly suppored by qemu, "

s/suppored/supported/

>+                         "use 'raw' instead"));
>+        return -1;

ACK

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180331/df05d9bb/attachment-0001.sig>