[libvirt] [PATCH v3 1/3] tpm: Enable TPM CRB interface in the domain XML and test it

[John Ferlan]

I'll change the $SUBJ to be:

conf: Enable TPM CRB interface in the domain XML

[follows convention we typically use]

On 04/26/2018 01:42 PM, Stefan Berger wrote:
> Enable the TPM CRB to be specified in the domain XML. This
> now allows to describe the TPM device like this:
> 
>   <tpm model='tpm-crb'>
>     <backend type='passthrough'>
>       <device path='/dev/tpm0'/>
>     </backend>
>   </tpm>
> 
> Extend the XML schema to also allow tpm-crb.
> Extend the documentation.
> Add a test case for testing the XML parser and formatter.
> 
> Signed-off-by: Stefan Berger <stefanb at linux.vnet.ibm.com>
> ---
>  docs/formatdomain.html.in                        |  6 +++-
>  docs/schemas/domaincommon.rng                    |  5 +++-
>  src/conf/domain_conf.c                           |  5 ++--
>  src/conf/domain_conf.h                           |  1 +
>  tests/qemuxml2argvdata/tpm-passthrough-crb.xml   | 32 +++++++++++++++++++++
>  tests/qemuxml2xmloutdata/tpm-passthrough-crb.xml | 36 ++++++++++++++++++++++++
>  tests/qemuxml2xmltest.c                          |  1 +
>  7 files changed, 81 insertions(+), 5 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/tpm-passthrough-crb.xml
>  create mode 100644 tests/qemuxml2xmloutdata/tpm-passthrough-crb.xml
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 8e864f7..d48e335 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -7625,7 +7625,8 @@ qemu-kvm -net nic,model=? /dev/null
>  
>      <p>
>        The TPM device enables a QEMU guest to have access to TPM
> -      functionality.
> +      functionality. The TPM device may either be a TPM 1.2 or
> +      a TPM 2.
>      </p>
>      <p>
>        The TPM passthrough device type provides access to the host's TPM
> @@ -7655,6 +7656,9 @@ qemu-kvm -net nic,model=? /dev/null
>            The <code>model</code> attribute specifies what device
>            model QEMU provides to the guest. If no model name is provided,
>            <code>tpm-tis</code> will automatically be chosen.
> +          <span class="since">Since 4.3.0</span>, another available choice

I'll change this to 4.4.0 before pushing...

> +          is the <code>tpm-crb</code>, which should only be used when the
> +          backend device is a TPM 2.
>          </p>
>        </dd>
>        <dt><code>backend</code></dt>

Reviewed-by: John Ferlan <jferlan at redhat.com>

John

[...]