[libvirt] [PATCH] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name

Eric Blake eblake at redhat.com
Tue May 1 13:17:14 UTC 2018


On 04/30/2018 10:01 AM, Maciej Wolny wrote:
> This caused an error on Debian, where the tool is called libtoolize, not
> libtool.

The commit message is incorrect (we are not trying to call the installed 
libtoolize program, but the just-built libtool script that resides in 
our tree), but the fix itself is correct.

> ---
>   tests/Makefile.am | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 7b93fbde6..05db6b119 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -487,7 +487,7 @@ VALGRIND = valgrind --quiet --leak-check=full --trace-children=yes \
>   	--trace-children-skip="*/tools/virsh","*/tests/commandhelper" \
>   	--suppressions=$(srcdir)/.valgrind.supp
>   valgrind:
> -	$(MAKE) check VG="libtool --mode=execute $(VALGRIND)"
> +	$(MAKE) check VG="$(LIBTOOL) --mode=execute $(VALGRIND)"
>   
>   sockettest_SOURCES = \
>   	sockettest.c \
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list