[libvirt] [PATCH 01/35] storage: Properly track that backing chain members are readonly

John Ferlan jferlan at redhat.com
Wed May 2 00:06:40 UTC 2018



On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Everything besides the top of the chain is readonly. Track this when
> parsing the XML and detecting the chain from the disk. Also fix the
> state when taking snapshots.
> 
> All other cases where the top image is changed already preserve the
> readonly state from the original image.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/conf/domain_conf.c    | 3 +++
>  src/qemu/qemu_driver.c    | 3 +++
>  src/util/virstoragefile.c | 1 +
>  3 files changed, 7 insertions(+)
> 

Any concerns with virDomainDiskDefCheckABIStability?  Since true would
now be the default - is it possible a save file comparison causes issues?

Reviewed-by: John Ferlan <jferlan at redhat.com>

John




More information about the libvir-list mailing list