[libvirt] [PATCH 01/35] storage: Properly track that backing chain members are readonly

[Peter Krempa]

On Tue, May 01, 2018 at 20:06:40 -0400, John Ferlan wrote:
> 
> 
> On 04/25/2018 11:15 AM, Peter Krempa wrote:
> > Everything besides the top of the chain is readonly. Track this when
> > parsing the XML and detecting the chain from the disk. Also fix the
> > state when taking snapshots.
> > 
> > All other cases where the top image is changed already preserve the
> > readonly state from the original image.
> > 
> > Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> > ---
> >  src/conf/domain_conf.c    | 3 +++
> >  src/qemu/qemu_driver.c    | 3 +++
> >  src/util/virstoragefile.c | 1 +
> >  3 files changed, 7 insertions(+)
> > 
> 
> Any concerns with virDomainDiskDefCheckABIStability?  Since true would
> now be the default - is it possible a save file comparison causes issues?

The ABI stability is checked only for the 'readonly' attribute of the
top layer, since that may have implications visible from the guest. The
rest of the backing chain definitely is not ABI.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180502/31f696b6/attachment-0001.sig>