[libvirt] [PATCH 25/35] tests: qemublock: Add basic 'raw' file test

[Peter Krempa]

On Wed, May 02, 2018 at 18:39:44 -0400, John Ferlan wrote:
> 
> 
> On 04/25/2018 11:15 AM, Peter Krempa wrote:
> > Test the JSON props generator with a very simple 'raw' image with no
> > other options. The node-names for the image are 31 bytes long so that we
> > validate our node name detector.
> > 
> > The top level disk image would generate the following '-drive' cmdline:
> > 
> > -drive file=/var/lib/libvirt/images/i.img,format=raw,if=none,id=drive-dummy
> > -device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy
> 
> One would think we'd be able to test that too ;-)

I've actually generated these by instrumenting the test function to call
the old generators as well. The thing is that the mapping to -drive
command line is valid only for now, when I'm striving to fully replace
-drive. Once blockdev is used new features will be added only to the
blockdev infrastructure so the mapping to -drive will become invalid.
Thus I chose to not test this aspect.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180503/7575733f/attachment-0001.sig>