[libvirt] [PATCH 2/6] storage: split gluster storage file code from storage driver backend

[Daniel P. Berrangé]

On Thu, Apr 26, 2018 at 09:39:44AM +0200, Peter Krempa wrote:
> On Wed, Apr 25, 2018 at 16:52:39 +0100, Daniel Berrange wrote:
> > The storage file code needs to be run in the hypervisor drivers, while
> > the storage backend code needs to be run in the storage driver. Split
> > the source code as a preparatory step for creating separate loadable
> > modules.
> 
> At first I thought it might be better to stash this into the storage
> driver, but when I went through this series I agree that this is not
> suited for the storage driver.
> 
> One of the benefits of having this separately would be that e.g. gluster
> will not leak it's stuff around the main qemu driver. Theoretically that
> could be achieved by yet another daemon for this functionality.
> 
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> >  src/storage/Makefile.inc.am           |   2 +
> >  src/storage/storage_backend_gluster.c | 305 +---------------------------
> >  src/storage/storage_backend_gluster.h |   2 +-
> >  src/storage/storage_file_gluster.c    | 366 ++++++++++++++++++++++++++++++++++
> >  src/storage/storage_file_gluster.h    |  27 +++
> >  5 files changed, 399 insertions(+), 303 deletions(-)
> >  create mode 100644 src/storage/storage_file_gluster.c
> >  create mode 100644 src/storage/storage_file_gluster.h
> 
> [...]
> 
> > diff --git a/src/storage/storage_backend_gluster.h b/src/storage/storage_backend_gluster.h
> > index 91b8d8275d..12a1c04f8d 100644
> > --- a/src/storage/storage_backend_gluster.h
> > +++ b/src/storage/storage_backend_gluster.h
> > @@ -1,7 +1,7 @@
> >  /*
> >   * storage_backend_gluster.h: storage backend for Gluster handling
> >   *
> > - * Copyright (C) 2013 Red Hat, Inc.
> > + * Copyright (C) 2013-2018 Red Hat, Inc.
> >   *
> >   * This library is free software; you can redistribute it and/or
> >   * modify it under the terms of the GNU Lesser General Public
> 
> You did not touch anything in this file other than the copyright.
> 
> [...]

Habit of touching date in all files in a commit...

> 
> > diff --git a/src/storage/storage_file_gluster.h b/src/storage/storage_file_gluster.h
> > new file mode 100644
> > index 0000000000..572254aedb
> > --- /dev/null
> > +++ b/src/storage/storage_file_gluster.h
> > @@ -0,0 +1,27 @@
> > +/*
> > + * storage_file_gluster.h: storage file backend for Gluster handling
> > + *
> > + * Copyright (C) 2013-2018 Red Hat, Inc.
> 
> There is no code from 2013 in this file yet, since the function is new.

Opps, cut & paste from the other file.

> 
> > + *
> > + * This library is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU Lesser General Public
> > + * License as published by the Free Software Foundation; either
> 
> ACK



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|