[libvirt] [dbus PATCH v2 2/9] Abandon usage of all *TypeToString functions in connect.c
Pavel Hrdina
phrdina at redhat.com
Fri May 4 14:08:27 UTC 2018
On Fri, May 04, 2018 at 10:38:28AM +0200, Katerina Koukiou wrote:
> Converting ENUMS to str can be user friendly though
> it can be problematic in matters of backward compatibility.
>
> In particular when some ENUM in libvirt API will introduce a
> new constant, libvirt-dbus will fail with:
>
> size of array ‘_GStaticAssertCompileTimeAssertion_5’ is negative
>
> So using ints is preferable to avoid the previous issue.
>
> Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
> ---
> data/org.libvirt.Connect.xml | 2 +-
> src/connect.c | 18 +-----------------
> 2 files changed, 2 insertions(+), 18 deletions(-)
Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180504/ac1a4aff/attachment-0001.sig>
More information about the libvir-list
mailing list