[libvirt] [dbus PATCH v2 3/9] Abandon usage of all *TypeToString functions in network.c
Pavel Hrdina
phrdina at redhat.com
Fri May 4 14:09:12 UTC 2018
On Fri, May 04, 2018 at 10:38:29AM +0200, Katerina Koukiou wrote:
> Converting ENUMS to str can be user friendly though
> it can be problematic in matters of backward compatibility.
>
> In particular when some ENUM in libvirt API will introduce a
> new constant, libvirt-dbus will fail with:
>
> size of array ‘_GStaticAssertCompileTimeAssertion_5’ is negative
>
> So using ints is preferable to avoid the previous issue.
>
> Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
> ---
> data/org.libvirt.Network.xml | 6 ++--
> src/network.c | 66 +++-----------------------------------------
> tests/test_network.py | 2 +-
> 3 files changed, 8 insertions(+), 66 deletions(-)
Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180504/1126b657/attachment-0001.sig>
More information about the libvir-list
mailing list