[libvirt] [dbus PATCH 10/19] Implement Name property for StoragePool Interface

Pavel Hrdina phrdina at redhat.com
Wed May 9 12:37:32 UTC 2018


On Mon, May 07, 2018 at 04:40:51PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
> ---
>  data/org.libvirt.StoragePool.xml |  4 ++++
>  src/storagepool.c                | 23 +++++++++++++++++++++++
>  tests/test_storage.py            |  1 +
>  3 files changed, 28 insertions(+)
> 
> diff --git a/data/org.libvirt.StoragePool.xml b/data/org.libvirt.StoragePool.xml
> index 29d501b..8bc90b7 100644
> --- a/data/org.libvirt.StoragePool.xml
> +++ b/data/org.libvirt.StoragePool.xml
> @@ -8,6 +8,10 @@
>        <annotation name="org.gtk.GDBus.DocString"
>            value="See https://libvirt.org/html/libvirt-libvirt-storage.html#virStoragePoolGetAutostart"/>
>      </property>
> +    <property name="Name" type="s" access="read">
> +      <annotation name="org.gtk.GDBus.DocString"
> +          value="See https://libvirt.org/html/libvirt-libvirt-storage.html#virStoragePoolGetName"/>
> +    </property>

This should be annotated as 'const' because there is no API to change
the name. The only way is to undefine it and define it again.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180509/84d81656/attachment-0001.sig>


More information about the libvir-list mailing list