[libvirt] [PATCH v2 04/12] virsh: Create macros for VSH_OT_STRING "domain" option

Michal Privoznik mprivozn at redhat.com
Thu May 10 09:17:18 UTC 2018


On 05/08/2018 04:20 PM, Lin Ma wrote:
> Signed-off-by: Lin Ma <lma at suse.com>
> ---
>  tools/virsh.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/tools/virsh.h b/tools/virsh.h
> index 9e717ef574..b1b641bc41 100644
> --- a/tools/virsh.h
> +++ b/tools/virsh.h
> @@ -110,6 +110,17 @@
>       .help = _helpstr \
>      }
>  
> +# define VIRSH_COMMON_OPT_DOMAIN_OT_STRING(_helpstr, cflags) \
> +    {.name = "domain", \
> +     .type = VSH_OT_STRING, \
> +     .help = _helpstr, \
> +     .completer = virshDomainNameCompleter, \
> +     .completer_flags = cflags, \
> +    }
> +
> +#define VIRSH_COMMON_OPT_DOMAIN_OT_STRING_FULL(cflags) \
> +    VIRSH_COMMON_OPT_DOMAIN_OT_STRING(N_("domain name, id or uuid"), cflags)

Again, missing space after #.

ACK with that fixed.

Michal




More information about the libvir-list mailing list