[libvirt] [PATCH] qemu: Remove parameter 'driver' from qemuBlockJobUpdate

Ján Tomko jtomko at redhat.com
Thu May 10 14:42:15 UTC 2018


On Thu, May 10, 2018 at 04:16:30PM +0200, Roland Schulz wrote:
>The pointer to the qemu driver is already included in domain object's
>private data, so does not need to be passed as yet another parameter
>when the domain object is already passed.
>
>Also removes parameter 'driver' from functions which had it just because of
>qemuBlockJobUpdate.
>
>Signed-off-by: Roland Schulz <schullzroll at gmail.com>
>---
>Follow up on BiteSizeTask
>https://wiki.libvirt.org/page/BiteSizedTasks#Clean_up_virQEMUDriverPtr_parameters
>
> src/qemu/qemu_blockjob.c  | 13 +++++--------
> src/qemu/qemu_blockjob.h  |  6 ++----
> src/qemu/qemu_driver.c    |  6 +++---
> src/qemu/qemu_migration.c | 29 +++++++++++++----------------
> 4 files changed, 23 insertions(+), 31 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180510/af6beead/attachment-0001.sig>


More information about the libvir-list mailing list