[libvirt] [PATCH v2 1/8] qemu: introduce capability for virtual-css-bridge

[Boris Fiuczynski]

On 05/10/2018 10:46 PM, John Ferlan wrote:
> 
> 
> On 05/07/2018 10:41 AM, Boris Fiuczynski wrote:
>> From: Shalini Chellathurai Saroja <shalini at linux.vnet.ibm.com>
>>
>> Let us introduce the capability QEMU_CAPS_CCW for virtual-css-bridge
>> and replace QEMU_CAPS_VIRTIO_CCW with QEMU_CAPS_CCW in code segments
>> which identify support for ccw devices.
>>
>> The virtual-css-bridge is part of the ccw support introduced in QEMU 2.7.
>> The QEMU_CAPS_CCW capability is based on the existence of the QEMU type.
>>
>> Let us also add the capability QEMU_CAPS_CCW to the tests which
>> require support for ccw devices.
>>
>> Signed-off-by: Shalini Chellathurai Saroja <shalini at linux.vnet.ibm.com>
>> Reviewed-by: Bjoern Walk <bwalk at linux.ibm.com>
>> Reviewed-by: Boris Fiuczynski <fiuczy at linux.ibm.com>
>> ---
>>   src/qemu/qemu_capabilities.c                     |  9 +++
>>   src/qemu/qemu_capabilities.h                     |  1 +
>>   src/qemu/qemu_domain.c                           |  2 +-
>>   src/qemu/qemu_domain_address.c                   |  4 +-
>>   src/qemu/qemu_hotplug.c                          |  4 +-
>>   tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml |  1 +
>>   tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml |  1 +
>>   tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml  |  1 +
>>   tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml  |  1 +
>>   tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml  |  1 +
>>   tests/qemuhotplugtest.c                          |  2 +-
>>   tests/qemuxml2argvtest.c                         | 86 ++++++++++++------------
>>   tests/qemuxml2xmltest.c                          | 26 +++----
>>   13 files changed, 77 insertions(+), 62 deletions(-)
>>
> 
> tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml
> 
> was missed on this patch - make check will fail, so it needs to be
> adjusted now so that bisection doesn't some day have problems. I see it
> was added in patch 2 and that
> 
> IOW:
> 
> +  <flag name='virtual-css-bridge'/>
You are right of course. It is a miss on my part. Patch 2 contains the 
change and I was to lazy to run an iterated apply patch and build which 
would have caught this. Sorry.

> 
> 
> You may also want to send a "final" v2.12.0 replies/caps patch later too...
You are right and Shalini has already prepared a patch to do so. She 
will send it out soon.

> 
> Reviewed-by: John Ferlan <jferlan at redhat.com>
> 
> John
Thanks

> 
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 


-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294