[libvirt] [PATCH] travis: Uninstall packages before upgrade

Michal Privoznik mprivozn at redhat.com
Mon May 14 14:12:11 UTC 2018


On 05/14/2018 12:07 PM, Andrea Bolognani wrote:
> numpy (needed by cgal) started having the same issue with
> linking as python, which makes upgrade and thus the entire
> build fail on macOS.
> 
> Instead of playing more tricks with linking/unlinking, just
> uninstall the problematic packages (and those dragging them
> in) before doing anything else.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
> Technically a build breaker, but since I'm changing the
> approach I'd rather wait for an explicit ACK before pushing.
> 
>  .travis.yml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index d3f72d46f3..140072b801 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -21,10 +21,10 @@ matrix:
>      - compiler: clang
>        os: osx
>        before_install:
> +        - brew uninstall python mercurial postgis sfcgal cgal gdal
>          - brew update
> -        - brew unlink python
>          - brew upgrade
> -        - brew install rpcgen yajl
> +        - brew install python rpcgen yajl
>        script:
>          # We can't run make distcheck/syntax-check because they
>          # fail on macOS, but doing 'install' and 'dist' gives us
> 

This OSX support is becoming more and more hairy. It's fairly often
broken and we do nothing but compile test it (we don't even run make
check there). So we can't be really sure the compiled virsh/client
library still works there. I think it's time to have a discussion about
dropping OSX support. Do we know if we even have any consumers running
libvirt on OSX?

Michal




More information about the libvir-list mailing list