[libvirt] [PATCH 05/13] util: storage: Drop pointless 'enabled' form PR definition

Michal Privoznik mprivozn at redhat.com
Mon May 14 15:19:52 UTC 2018


On 05/14/2018 12:41 PM, Peter Krempa wrote:
> Everything can be disabled by not using the parent element. There's no
> need to store this explicitly. Additionally it does not add any value
> since any configuration is dropped if enabled='no' is configured.
> 
> Drop the attribute and adjust the code accordingly.t

s/t$//

> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  docs/formatdomain.html.in                          |  21 ++--
>  docs/schemas/storagecommon.rng                     |   3 -
>  src/util/virstoragefile.c                          | 117 +++++++++------------
>  src/util/virstoragefile.h                          |   1 -
>  .../disk-virtio-scsi-reservations.xml              |   4 +-
>  5 files changed, 59 insertions(+), 87 deletions(-)

Michal




More information about the libvir-list mailing list