[libvirt] [PATCH 08/12] storage_util: Split backing_fmt set in storageBackendCreateQemuImgOpts

Peter Krempa pkrempa at redhat.com
Tue May 15 13:36:05 UTC 2018


On Tue, May 08, 2018 at 08:48:01 -0400, John Ferlan wrote:
> The only way backing_fmts could be set is if the info->format was
> not RAW (see storageBackendCreateQemuImgSetBacking), so let's just
> extract it from the if/else surrounding the application of the
> encryption options.

Well, technically backingFmt and backing path only make sense for
non-RAW disks. The condition below is weird though. The code was
introduced by a combination of the commits adding LUKS support and then
reverting the type.

Given that prior to those commits it was indeed always executed, we can
safely change it.

ACK

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180515/47b5a47a/attachment-0001.sig>


More information about the libvir-list mailing list