[libvirt] [PATCH 0/9] Some virsh completion fixes

[Michal Privoznik]

On 05/15/2018 01:10 PM, Lin Ma wrote:
> patch 1 is not about completion, I merge it into this patch set for
> easy review because it's a tiny fix.
> 
> Lin Ma (9):
>   virsh: Remove 'id' text from help message for 'domrename' command
>   virsh: Only return active domain names for 'reset' command
>   virsh: Only return active domain names for block* command
>   virsh-network: Create macros for VSH_OT_STRING "network" option
>   virsh-network: Add network name completion to 'net-event' command
>   virsh-network: Add macro VIRSH_COMMON_OPT_NETWORK_FULL
>   virsh-network: Add network name completion to 'net-uuid' command
>   virsh: Introduce virshDomainBlockTargetCompleter
>   virsh: Add target name completion for block device options
> 
>  tools/virsh-completer.c      | 48 ++++++++++++++++++++++++++++++++++++++++++++
>  tools/virsh-completer.h      |  4 ++++
>  tools/virsh-domain-monitor.c |  2 ++
>  tools/virsh-domain.c         | 23 ++++++++++++++-------
>  tools/virsh-network.c        | 47 +++++++++++++++++++++++++------------------
>  5 files changed, 97 insertions(+), 27 deletions(-)
> 

Not quite sure how you sent the patches but they are broken in two
separate threads.

Anyway, ACK to all of them. I've renamed the function from 8/9 and
adjusted 9/9 accordingly.

Thanks. Also thanks for proving how easy it is to write new completers.
Hopefully we can get more of them.

Michal