[libvirt] [PATCH 1/4] qemu: command: Optimize formatting of 'passwordid' in qemuBuildTLSx509BackendProps

Peter Krempa pkrempa at redhat.com
Thu May 17 15:17:32 UTC 2018


Use the 'S' modifier for create the field optionally rather than calling
another JSON formatter function.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_command.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index c4237339bf..173745ee49 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -731,13 +731,10 @@ qemuBuildTLSx509BackendProps(const char *tlspath,
                                  "s:dir", path,
                                  "s:endpoint", (isListen ? "server": "client"),
                                  "b:verify-peer", (isListen ? verifypeer : true),
+                                 "S:passwordid", secalias,
                                  NULL) < 0)
         goto cleanup;

-    if (secalias &&
-        virJSONValueObjectAdd(*propsret, "s:passwordid", secalias, NULL) < 0)
-        goto cleanup;
-
     ret = 0;

  cleanup:
-- 
2.16.2




More information about the libvir-list mailing list