[libvirt] [PATCH] qemu: Add support for -device hda-output (disable line-in)

[Erik Skultety]

On Thu, May 17, 2018 at 12:11:12AM +0200, Filip Alac wrote:
> Add support for hda 'output' codec for ich6 and ich9 sound devices,
> which allow us to disable line-in for guest.
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=1126641
>
> Signed-off-by: Filip Alac <filipalac at gmail.com>
> ---
>  docs/formatdomain.html.in                               | 5 +++--
>  docs/schemas/domaincommon.rng                           | 1 +
>  src/conf/domain_conf.c                                  | 3 ++-
>  src/conf/domain_conf.h                                  | 1 +
>  src/qemu/qemu_capabilities.c                            | 2 ++
>  src/qemu/qemu_capabilities.h                            | 1 +
>  src/qemu/qemu_command.c                                 | 5 ++++-
>  tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml        | 1 +
>  tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml        | 1 +
>  tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml        | 1 +
>  tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml        | 1 +
>  tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml      | 1 +
>  tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml        | 1 +
>  tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml       | 1 +
>  tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml      | 1 +
>  tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml        | 1 +
>  tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml       | 1 +
>  tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml        | 1 +
>  tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml        | 1 +
>  tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml       | 1 +
>  tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml         | 1 +
>  tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml        | 1 +
>  tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml        | 1 +
>  tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml        | 1 +
>  tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml         | 1 +
>  tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml        | 1 +
>  tests/qemustatusxml2xmldata/migration-in-params-in.xml  | 1 +
>  tests/qemustatusxml2xmldata/migration-out-nbd-in.xml    | 1 +
>  tests/qemustatusxml2xmldata/migration-out-nbd-out.xml   | 1 +
>  tests/qemustatusxml2xmldata/migration-out-params-in.xml | 1 +
>  tests/qemustatusxml2xmldata/modern-in.xml               | 1 +
>  tests/qemuxml2argvdata/sound-device.args                | 2 ++
>  tests/qemuxml2argvdata/sound-device.xml                 | 2 ++
>  tests/qemuxml2argvtest.c                                | 1 +
>  tests/qemuxml2xmloutdata/sound-device.xml               | 2 ++
>  35 files changed, 45 insertions(+), 4 deletions(-)
>
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 0d0fd3b9..8ab45e1c 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -7388,8 +7388,9 @@ qemu-kvm -net nic,model=? /dev/null
>        sub-elements <code><codec></code> to attach various audio
>        codecs to the audio device. If not specified, a default codec
>        will be attached to allow playback and recording. Valid values
> -      are 'duplex' (advertise a line-in and a line-out) and 'micro'
> -      (advertise a speaker and a microphone).
> +      are 'duplex' (advertise a line-in and a line-out), 'micro'
> +       (advertise a speaker and a microphone) and 'output'
> +       (advertise a speaker).

QEMU reports the description as line-out, so we should keep in sync with that,
also, we should document since what libvirt release we support the new value,
which in this case will be 4.4.0 once it's out.

Other than that, I don't see any issues with the patch and the audio device
features reported within guest correspond too.

I'll fix the little nit above and push the patch tomorrow.

Reviewed-by: Erik Skultety <eskultet at redhat.com>