[libvirt] [PATCH 05/22] Improve documentation of virConnectGetCPUModelNames
Collin Walling
walling at linux.ibm.com
Tue May 22 21:46:41 UTC 2018
On 05/16/2018 04:39 AM, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
> src/libvirt-host.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/src/libvirt-host.c b/src/libvirt-host.c
> index 76087badd8..ed689b9ec2 100644
> --- a/src/libvirt-host.c
> +++ b/src/libvirt-host.c
> @@ -1003,7 +1003,13 @@ virConnectCompareCPU(virConnectPtr conn,
> * NULL if only the list length is needed.
> * @flags: extra flags; not used yet, so callers should always pass 0.
> *
> - * Get the list of supported CPU models for a specific architecture.
> + * Get the list of CPU models supported by libvirt for a specific architecture.
> + *
> + * The returned list limits CPU models usable with libvirt (empty list means,
> + * there's no limit imposed by libvirt) and it does not reflect capabalities of
s/capabalities/capabilities
> + * any hypervisor. See the XML returned by virConnectGetDomainCapabilities()
> + * for a list of CPU models supported by libvirt for domains created on a
> + * specific hypervisor.
> *
> * Returns -1 on error, number of elements in @models on success (0 means
> * libvirt accepts any CPU model).
>
Other than that:
Reviewed-by: Collin Walling <walling at linux.ibm.com>
--
Respectfully,
- Collin Walling
More information about the libvir-list
mailing list