[libvirt] [PATCH 05/22] Improve documentation of virConnectGetCPUModelNames

Ján Tomko jtomko at redhat.com
Thu May 24 14:02:59 UTC 2018


On Wed, May 16, 2018 at 10:39:24AM +0200, Jiri Denemark wrote:
>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
>---
> src/libvirt-host.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/src/libvirt-host.c b/src/libvirt-host.c
>index 76087badd8..ed689b9ec2 100644
>--- a/src/libvirt-host.c
>+++ b/src/libvirt-host.c
>@@ -1003,7 +1003,13 @@ virConnectCompareCPU(virConnectPtr conn,
>  *          NULL if only the list length is needed.
>  * @flags: extra flags; not used yet, so callers should always pass 0.
>  *
>- * Get the list of supported CPU models for a specific architecture.
>+ * Get the list of CPU models supported by libvirt for a specific architecture.
>+ *
>+ * The returned list limits CPU models usable with libvirt (empty list means,

Should there be a comma?

>+ * there's no limit imposed by libvirt) and it does not reflect capabalities of
>+ * any hypervisor. See the XML returned by virConnectGetDomainCapabilities()
>+ * for a list of CPU models supported by libvirt for domains created on a
>+ * specific hypervisor.
>  *

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180524/0ec75ea1/attachment-0001.sig>


More information about the libvir-list mailing list