[libvirt] [PATCH 08/22] Introduce virConnectCompareHypervisorCPU public API

Ján Tomko jtomko at redhat.com
Thu May 24 14:45:42 UTC 2018


On Wed, May 16, 2018 at 10:39:27AM +0200, Jiri Denemark wrote:
>This new API compares the given CPU description with the CPU the
>specified hypervisor is able to provide on the host. It is a more useful
>version of virConnectCompareCPU, which compares the CPU definition with
>the host CPU without considering any specific hypervisor and its
>abilities.
>
>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
>---
> include/libvirt/libvirt-host.h |  7 ++++
> src/driver-hypervisor.h        | 10 +++++
> src/libvirt-host.c             | 72 +++++++++++++++++++++++++++++++++-
> src/libvirt_public.syms        |  5 +++
> 4 files changed, 93 insertions(+), 1 deletion(-)
>
>diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h
>index 07b5d15943..e2054baebc 100644
>--- a/include/libvirt/libvirt-host.h
>+++ b/include/libvirt/libvirt-host.h
>diff --git a/src/libvirt-host.c b/src/libvirt-host.c
>index ed689b9ec2..17cf183499 100644
>--- a/src/libvirt-host.c
>+++ b/src/libvirt-host.c
>@@ -954,7 +954,11 @@ virConnectIsSecure(virConnectPtr conn)
>  * @xmlDesc: XML describing the CPU to compare with host CPU
>  * @flags: bitwise-OR of virConnectCompareCPUFlags
>  *
>- * Compares the given CPU description with the host CPU
>+ * Compares the given CPU description with the host CPU.
>+ *
>+ * See vitConnectCompareHypervisorCPU() if you want to consider hypervisor

s/vit/vir/

>+ * abilities and compare the CPU to the CPU which a hypervisor is able to
>+ * provide on the host.
>  *
>  * Returns comparison result according to enum virCPUCompareResult. If
>  * VIR_CONNECT_COMPARE_CPU_FAIL_INCOMPATIBLE is used and @xmlDesc CPU is

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180524/3d2aeb56/attachment-0001.sig>


More information about the libvir-list mailing list