[libvirt] [PATCH] disk: Allow settling to occur after reading partitions

Michal Privoznik mprivozn at redhat.com
Fri May 25 06:42:10 UTC 2018


On 05/24/2018 05:43 PM, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1400475
> 
> In order to avoid a possible error as a result of kernel interactions
> with the partition helper, let's use virWaitForDevices to force things
> to settle down before attempting to open and read the partition. This
> is related to https://bugzilla.redhat.com/show_bug.cgi?id=1264719.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
> 
>  NB: This also resolves issues seen while testing the patch with using
>      pool-refresh "frequently" on the disk pool. Perhaps the timing of
>      things has changed enough that it'd be see more often now. At least
>      with the f26 test system I used.
> 
>      BTW: The other option proposed long ago, but rejected was adding
>      a timeout loop.  I've also run the python script from the other
>      bz with 100% success.
> 
>  src/storage/storage_backend_disk.c | 9 +++++++++
>  1 file changed, 9 insertions(+)

ACK

Michal




More information about the libvir-list mailing list