[libvirt] [PATCH 04/22] virsh: Enhance documentation of cpu-models command

[Kashyap Chamarthy]

On Fri, May 25, 2018 at 11:36:21AM +0200, Jiri Denemark wrote:
> On Thu, May 24, 2018 at 11:05:08 +0200, Kashyap Chamarthy wrote:

[...]

> > Ah, that is clearer; thank you.  So if you think it is worth it, maybe
> > adjust your doc patch to a variant of the following:
> > 
> >     Moreover, for some architectures libvirt does not know any CPU
> >     models and the usable CPU models are only limited by the hypervisor
> >     (e.g. to enumerate a list of acceptable CPU models for AArch64, use
> >     `virsh domcapabilities --arch aarch64`; likewise for 's390x').
> 
> So how about
> 
>     Print the list of CPU models known by libvirt for the specified
>     architecture. Whether a specific hypervisor is able to create a
>     domain which uses any of the printed CPU models is a separate
>     question which can be answered by looking at the domain capabilities
>     XML returned by B<domcapabilities> command. Moreover, for some
>     architectures libvirt does not know any CPU models and the usable
>     CPU models are only limited by the hypervisor. This command will
>     print that all CPU models are accepted for these architectures and
>     the actual list of supported CPU models can be checked in the domain
>     capabilities XML.

Yep, clear and to the point.  Thanks.

Reviewed-by: Kashyap Chamarthy <kchamart at redhat.com>

-- 
/kashyap