[libvirt] [PATCH 10/22] virsh: Introduce new hypervisor-cpu-compare command

[Collin Walling]

>>> +    switch (result) {
>>> +    case VIR_CPU_COMPARE_INCOMPATIBLE:
>>> +        vshPrint(ctl,
>>> +                 _("CPU described in %s is incompatible with the CPU provided "
>>> +                   "by hypervisor on the host\n"),
>>> +                 from);
>>
>> How much information regarding a CPU definition does libvirt consider when comparing CPU's
>> for x86 (and for other archs, if you happen to know)? On s390, we only take the cpu model 
>> and features into consideration.
>>
>> If the archs other than s390 will only use the cpu model and features as well -- or if this 
>> API should explicitly work only with CPU models -- then perhaps it is more accurate for these 
>> messages to state "CPU model" instead of "CPU"? This change would also have to be propagated 
>> in to the documentation, replacing "CPU definition" with "CPU model".
> 
> It doesn't really matter what libvirt currently checks for which
> architecture. The API takes a CPU definition XML and libvirt will use
> anything it needs from that.
> 

I had to bat this around in my head a bit. Truthfully, I think trying to expand on
why we got the result might be a little much. Perhaps I should have more faith in the
user to understand what is taken into consideration when CPUs are compared :)

Reviewed-by: Collin Walling <walling at linux.ibm.com>

-- 
Respectfully,
- Collin Walling