[libvirt] [PATCH v2 09/12] qemuDomainDetachDeviceLiveAndConfig: Avoid overwriting @ret

[Ján Tomko]

On Thu, May 24, 2018 at 01:13:36PM +0200, Michal Privoznik wrote:
>The fact that we are overwriting @ret multiple times is very
>confusing to see what is actually happening here.

-EPARSE
s/is very confusing/makes it difficult to see/

>Follow our
>traditional pattern where @ret is initialized to -1, and set to 0
>only in case we know we succeeded.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_driver.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180526/c56d1256/attachment-0001.sig>