[libvirt] [PATCHv2 3/3] xen_common: convert to typesafe virConf accessors

[Ján Tomko]

On Sun, May 27, 2018 at 02:08:58PM +0200, Fabiano Fidêncio wrote:
>On Sun, May 27, 2018 at 1:17 PM, Ján Tomko <jtomko at redhat.com> wrote:
>> On Sat, May 26, 2018 at 11:00:27PM +0200, Fabiano Fidêncio wrote:
>>>
>>> From: Fabiano Fidêncio <fidencio at redhat.com>
>>>
>>> There are still some places using virConfGetValue() and then checking
>>> the specific type of the pointers and so on.
>>>
>>> Those place are not going to be changed as:
>>> - Directly using virConfGetValue*() would trigger virReportError() on
>>> their current code
>>
>>
>> Is that a problem in xenParseCPUFeatures?
>
>It would, at least, generate one more log, which would be misleading
>whoever ends up debugging some issue on that codepath later on.
>

I don't see it.
xenConfigGetULong already reports an error when the "maxvcpus" value is
malformed.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180528/4761688c/attachment-0001.sig>