[libvirt] [PATCH 02/10] virCryptoGenerateRandom: rename ret

Eric Blake eblake at redhat.com
Tue May 29 20:20:25 UTC 2018


On 05/29/2018 03:24 AM, Michal Privoznik wrote:
> This function allocates a buffer, fills it in with random bytes
> and then returns it. However, the buffer is held in @buf
> variable, therefore having @ret variable which does not hold
> return value of the function is misleading.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>   src/util/vircrypto.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list