[libvirt] [PATCH] vmx: Remove check that numvcpus has to be an even number.

[Richard W.M. Jones]

This patch removes what appears to be an unnecessary check in the VMX
driver which is preventing us from importing guests that have an odd
number of vCPUs with virt-v2v.

Unfortunately to test this it seems you need a real VMware server
somewhere (substitute for ‘example.com’ below).

Download the VMX file attached to
https://bugzilla.redhat.com/show_bug.cgi?id=1584091

$ virsh -c 'esx://example.com' domxml-from-native vmware-vmx window2016.vmx 
Enter root's password for example.com: 
error: internal error: Expecting VMX entry 'numvcpus' to be an unsigned integer (1 or a multiple of 2) but found 7

After applying the patch:

$  ~/d/libvirt/run ~/d/libvirt/tools/virsh -c 'esx://example.com' domxml-from-native vmware-vmx window2016.vmx 
Enter root's password for example.com: 
<domain type='vmware'>
  ...
  <cpu>
    <topology sockets='1' cores='7' threads='1'/>
...

Rich.