[libvirt] [PATCH 12/38] qemu: domain: Regenerate auth/enc secret aliases when restoring status XML

Ján Tomko jtomko at redhat.com
Wed May 30 16:33:35 UTC 2018


On Wed, May 30, 2018 at 02:41:08PM +0200, Peter Krempa wrote:
>Previously we did not store the aliases but rather re-generated them
>when unplug was necessary. This is very cumbersome since the knowledge
>when and which alias to use needs to be stored in the hotplug code as
>well.
>
>While this patch will not strictly improve this situation since there
>still will be two places containing this code it at least will allow to
>remove the mess from the disk-unplug code and will prevent introducing
>more mess when adding blockdev support.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_domain.c                             | 90 +++++++++++++++++++++-
> .../disk-secinfo-upgrade-out.xml                   | 16 ++++
> 2 files changed, 105 insertions(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180530/823947bd/attachment-0001.sig>


More information about the libvir-list mailing list