[libvirt] [PATCH 15/38] qemu: domain: Store and restore TLS object alias of a disk

[Ján Tomko]

On Wed, May 30, 2018 at 02:41:11PM +0200, Peter Krempa wrote:
>Libvirt uses the stored alias to detach the tlx x509 object on disk

s/tlx/TLS/

>unplug. As the alias was not stored, the object would not be detached
>if unplugging disks after libvirtd restart.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_domain.c                    | 5 +++++
> tests/qemustatusxml2xmldata/modern-in.xml | 1 +
> 2 files changed, 6 insertions(+)
>
>diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
>index d070c013a1..a98424cc62 100644
>--- a/src/qemu/qemu_domain.c
>+++ b/src/qemu/qemu_domain.c
>@@ -2023,6 +2023,7 @@ qemuStorageSourcePrivateDataParse(xmlXPathContextPtr ctxt,
>
>     src->nodestorage = virXPathString("string(./nodenames/nodename[@type='storage']/@name)", ctxt);
>     src->nodeformat = virXPathString("string(./nodenames/nodename[@type='format']/@name)", ctxt);
>+    src->tlsAlias = virXPathString("string(./objects/tlsX509/@alias)", ctxt);
>
>     if (src->pr)
>         src->pr->mgralias = virXPathString("string(./reservations/@mgralias)", ctxt);
>@@ -2102,6 +2103,10 @@ qemuStorageSourcePrivateDataFormat(virStorageSourcePtr src,
>         qemuStorageSourcePrivateDataFormatSecinfo(&tmp, srcPriv->encinfo, "encryption");
>     }
>
>+    if (src->tlsAlias)
>+        virBufferAsprintf(&tmp, "<tlsX509 alias='%s'/>\n", src->tlsAlias);
>+
>+

Extra empty line.

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180530/41f1ca82/attachment-0001.sig>