[libvirt] [PATCH 30/38] qemu: command: Pass in alias for TLS object to qemuBuildTLSx509CommandLine

[Ján Tomko]

On Wed, May 30, 2018 at 02:41:26PM +0200, Peter Krempa wrote:
>Callers need to know the alias anyways so it does not make much sense to
>generate it inside of this function.
>
>Note that there's a lingering bad design of this, since the secret
>object alias is based on the device name and not on the fact that the
>secret is used for decrypting of the TLS private key. If we ever add
>authentication for chardevs this will bite us.
>
>Thankfully disk code does not support encrypted private keys for TLS so
>it can be happily refactored there.
>

Do these two paragraphs need to be repeated here?

>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_command.c | 26 +++++++++++---------------
> 1 file changed, 11 insertions(+), 15 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180530/7560e7c7/attachment-0001.sig>