[libvirt] [PATCH 12/38] qemu: domain: Regenerate auth/enc secret aliases when restoring status XML

[Peter Krempa]

On Wed, May 30, 2018 at 17:45:28 -0400, John Ferlan wrote:
> 
> 
> On 05/30/2018 08:41 AM, Peter Krempa wrote:
> > Previously we did not store the aliases but rather re-generated them
> > when unplug was necessary. This is very cumbersome since the knowledge
> > when and which alias to use needs to be stored in the hotplug code as
> > well.
> > 
> > While this patch will not strictly improve this situation since there
> > still will be two places containing this code it at least will allow to
> > remove the mess from the disk-unplug code and will prevent introducing
> > more mess when adding blockdev support.
> > 
> > Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> > ---
> >  src/qemu/qemu_domain.c                             | 90 +++++++++++++++++++++-
> >  .../disk-secinfo-upgrade-out.xml                   | 16 ++++
> >  2 files changed, 105 insertions(+), 1 deletion(-)
> > 
> 
> Just dawned on me - what about hostdev/iscsi?  for alias saving et. al.
> Patch 2 uses common API's to set up secrets for hostdev, but what would
> store the alias for them?  Or is that in some future patch I haven't
> read yet?

Hostdevs don't make sense with full backing chains so fixing that will
not be critical for adding -blockdev support there. I will see whether
that is required when trying to use blockdev for the hostdev.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180531/79a7f991/attachment-0001.sig>