[libvirt] What is the strategy to update the CPU Models in src/cpu/cpu_map.xml based on?

[Dou Liyang]

Hi Jirka,

At 05/30/2018 10:18 PM, Jiri Denemark wrote:
> On Wed, May 30, 2018 at 21:11:35 +0800, Dou Liyang wrote:
>> Hi Peter,
>>
>> Thank you for reply.
>>
>> At 05/30/2018 08:00 PM, Peter Krempa wrote:
>>>
>>> [re-adding libvir-list]
>>>
>>> On Wed, May 30, 2018 at 19:36:10 +0800, Dou Liyang wrote:
>>>> Hi Peter,
>>>>
>>>> Sorry to trouble you offline.
>>>
>>> Please keep conversations on the list, so that it does not get lost in
>>> private inboxes.
>>>
>>>> Recently, I forced on the PCID feature in CPU and
>>>> found the SandyBridge didn't include the PCID feature
>>>> in libvirt.
>>>>
>>>> commit cad8054ece285d1712880cd108e8a39f833f7e88
>>>> Author: Peter Krempa <pkrempa at redhat.com>
>>>> Date:   Wed Feb 8 12:43:07 2012 +0100
>>>>
>>>>     cpu: Add cpu definition for Intel Sandy Bridge cpu type
>>
>> Just curious why did the commit not add the PCID directly?
> 
> I guess because even QEMU did not support PCID at that point. As Peter
> already said, it was added to QEMU 5 months later:
> 

Yeah, I understand, thank you so much.

dou

>>> Qemu added it later than libvirt added the sandy-bridge cpu:
>>>
>>> commit 434acb817b8ae747f31e91ec152f9f47ac514433
>>> Author: Mao, Junjie <junjie.mao at intel.com>
>>> Date:   Fri Jul 20 07:08:21 2012 +0000
>>>
>>>       Recognize PCID feature
>>>       
>>>       This patch makes Qemu recognize the PCID feature specified from configuration or command line options.
> 
> Jirka
> 
> 
>