[libvirt] [PATCH v2 2/3] qemu: Restore lost shutdown reason
Michal Privoznik
mprivozn at redhat.com
Tue Nov 6 09:38:15 UTC 2018
On 11/01/2018 05:04 PM, John Ferlan wrote:
> When qemuProcessReconnectHelper was introduced (commit d38897a5d)
> reconnection failure used VIR_DOMAIN_SHUTOFF_FAILED; however, that
> was changed in commit bda2f17d to either VIR_DOMAIN_SHUTOFF_CRASHED
> or VIR_DOMAIN_SHUTOFF_UNKNOWN.
>
> When QEMU_CAPS_NO_SHUTDOWN checking was removed in commit fe35b1ad6
> the conditional state was just left at VIR_DOMAIN_SHUTOFF_CRASHED.
>
> So introduce qemuDomainIsUsingNoShutdown which will manage the
> condition when the domain was started with -no-shutdown so that
> when/if reconnection failure occurs we can restore the decision
> point used to determine whether CRASHED or UNKNOWN is provided.
>
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
> src/qemu/qemu_command.c | 6 +-----
> src/qemu/qemu_domain.c | 17 +++++++++++++++++
> src/qemu/qemu_domain.h | 3 +++
> src/qemu/qemu_process.c | 15 ++++++++++-----
> 4 files changed, 31 insertions(+), 10 deletions(-)
ACK
Michal
More information about the libvir-list
mailing list